[core] Split version name on the correct separator #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In adbdd3b, the version name for develop versions has been updated to use the "+" separator instead of "-". When loading a scene that has been saved since this change, errors occur during the parsing of the version name as the "+" is not expected. This commit fixes this issue by declaring "+" as the separator. Scenes that were saved with "-" remain compatible, as we replace all "-" in the version name with "+" before splitting it.
cbentejac
requested review from
Alxiice,
fabiencastan and
servantftransperfect
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2906 +/- ##
========================================
Coverage 79.52% 79.52%
========================================
Files 51 51
Lines 6975 6976 +1
========================================
+ Hits 5547 5548 +1
Misses 1428 1428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alxiice
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an oversight of #2904 by updating the version parsing logic in
meshroom/core/__init__.pyto improve compatibility with different version string formats. The most important change is that the function now treats both-and+as valid separators for the status component of the version, ensuring compatibility with scenes created in Meshroom 2025.1.0 or earlier.Version parsing compatibility:
toComponentsfunction to replace-with+inversionNamebefore splitting, so that both separators are handled consistently for status extraction. This maintains compatibility with older and newer version naming conventions.